Fix menu behaviour (#253) #255

dhardy · 2021-10-11T13:58:18Z

Fixes #253, and in general menu behaviour:

close open menu when clicking menubar and when window loses focus
tighter event handling: TkAction::CLOSE is no longer an acceptable way of closing a popup (was unused); remove Event::NewPopup; close all descendants of a popup before the popup itself
restrict setting navigation focus on popup open/close to (mostly) keyboard input since with the mouse this is redundant or wrong
clear character-input focus when clearing navigation focus
rewrite handling of arrow-key input

…t_string Also remove some useless code.

dhardy added 12 commits September 30, 2021 09:23

Menubar: close menu with click on bar

b80bfc1

Close popups on focus lost

47ea394

Remove Event::NewPopup: directly close non-ancestor popups instead

531f757

TkAction::CLOSE is not a valid way to close a popup

569abef

When closing a popup close all descendants first

8a1090a

When opening a menu, do not set navigation focus if activated via mouse

59c71e0

Clear char focus when clearing nav focus

07f0946

Fix crash: text editing due to index-out-of-range after EditField::se…

44bb790

…t_string Also remove some useless code.

Remove empty file

4bddd76

Add as_direction() for Command, impl Display for Direction

b2f69d2

Rewrite menu key handling

41e556c

Fine-tune restore-focus-on-popup-close behaviour

d26c4aa

dhardy merged commit 3c5ce3a into master Oct 11, 2021

Provide feedback